[3.2] response to disallowed host #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
requested changes
Apr 10, 2023
heifner
approved these changes
Apr 11, 2023
spoonincode
reviewed
Apr 11, 2023
|
|
||
| if cluster.launch(dontBootstrap=True, loadSystemContract=False) is False: | ||
| if cluster.launch(dontBootstrap=True, loadSystemContract=False, specificExtraNodeosArgs = {0: "--http-validate-host true"}) is False: |
There was a problem hiding this comment.
Do you really need --http-validate-host true here? It's the default.
There was a problem hiding this comment.
Yes, I have to. Somewhere in the TestHarness changed it to false.
Line 362 in 1a8d88f
There was a problem hiding this comment.
ah okay, it's interesting because you can't --http-validate-host true --http-validate-host true nor
http-validate-host = true
http-validate-host = true
But you can http-validate-host = true & --http-validate-host true
spoonincode
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the problem where HTTP plugin doesn't response to requests with disallowed HTTP HOST header.
Resolve IS #859