[2.0] Enable /v1/producer/pause_at_block
#1057
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
approved these changes
Dec 6, 2024
tests/pause_at_block_test.py
Outdated
Comment on lines
71
to
73
| assert headNode.getHeadBlockNum() == blockNum, "Head Node_02 did not pause at block" | ||
| assert specNode.getHeadBlockNum() == blockNum, "Speculative Node_03 did not pause at block" | ||
| assert irrvNode.getHeadBlockNum() == blockNum, "Irreversible Node_04 did not pause at block" |
There was a problem hiding this comment.
Regarding the comments, above we have headNode = cluster.getNode(3). Wouldn't that make it Node_03?
There was a problem hiding this comment.
Thanks. I added another node and didn't update the comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs to wait for 2.0.
Enable new
/v1/producer/pause_at_blockendpoint for pausing a node at a particular block number. Use/v1/producer/resumeto resume after pause.Resolves #570