Svnn ibc proof generation #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with hs_bitset internal storage
…c bitset class and added comments
…peIO/spring into svnn_ibc_proof_generation
|
Note:start |
linh2931
reviewed
Apr 18, 2024
greg7mdp
reviewed
Apr 19, 2024
greg7mdp
approved these changes
Apr 22, 2024
linh2931
approved these changes
Apr 22, 2024
greg7mdp
reviewed
Apr 29, 2024
|
|
||
| uint32_t block_num; | ||
|
|
||
| checksum256 finality_mroot; | ||
|
|
||
| time_point cache_expiry; | ||
|
|
||
| uint64_t primary_key()const { return id; } | ||
| uint64_t by_block_num()const { return block_num; } | ||
| //uint64_t primary_key()const { return id; } |
There was a problem hiding this comment.
please remove commented line.
|
|
||
| }; | ||
|
|
||
| TABLE lastproof { | ||
|
|
||
| uint64_t id; | ||
| //uint64_t id; |
There was a problem hiding this comment.
please remove commented line.
| @@ -100,20 +94,20 @@ CONTRACT svnn_ibc : public contract { | |||
| } | |||
|
|
|||
| struct quorum_certificate { | |||
| std::vector<uint64_t> finalizers; | |||
| bls_signature signature; | |||
| std::vector<uint32_t> finalizers; | |||
There was a problem hiding this comment.
I believe we switched to std::vector<uint8_t> in spring.
| if (pairIndex<leaf_count) proof_path.push_back(isLeft); | ||
|
|
||
| leaf_count/=2; | ||
| leaf_index=leaf_index / 2; |
There was a problem hiding this comment.
why not /=2 to be consistent with line above?
linh2931
approved these changes
Apr 30, 2024
Co-authored-by: Gregory Popovitch <greg7mdp@gmail.com>
…peIO/spring into svnn_ibc_proof_generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the standalone svnn_ibc unit test to include proof generation. Resolves #90.