Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0-beta4 -> main] Watermark violation should create speculative block #473

Merged
merged 3 commits into from
Aug 5, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Aug 5, 2024

Failing watermark validation would cause node to go into tight spin:

error 2024-08-01T19:05:54.914 nodeos    producer_plugin.cpp:1893      start_block          ] Not producing block because "defproducerd" signed a block at the next block time or later (2024-08-01T19:05:55.000) than the pending block time (2024-08-01T19:05:55.000)
debug 2024-08-01T19:05:54.914 nodeos    producer_plugin.cpp:2554      schedule_production_ ] Waiting till another block is received and scheduling Speculative/Production Change
debug 2024-08-01T19:05:54.914 nodeos    producer_plugin.cpp:2628      schedule_delayed_pro ] Scheduling Speculative/Production Change at 2024-08-01T19:05:54.887
... [snip over 2000 entries]
error 2024-08-01T19:05:54.999 nodeos    producer_plugin.cpp:1893      start_block          ] Not producing block because "defproducerd" signed a block at the next block time or later (2024-08-01T19:05:55.000) than the pending block time (2024-08-01T19:05:55.000)
debug 2024-08-01T19:05:54.999 nodeos    producer_plugin.cpp:2554      schedule_production_ ] Waiting till another block is received and scheduling Speculative/Production Change
debug 2024-08-01T19:05:55.000 nodeos    producer_plugin.cpp:2628      schedule_delayed_pro ] Scheduling Speculative/Production Change at 2024-08-01T19:05:55.350

Move block time check in speculative mode above watermark check in production mode.

Merges release/1.0-beta4 into main including #471

Reolves: AntelopeIO/leap#2380

@heifner heifner requested review from greg7mdp and linh2931 August 5, 2024 19:38
@heifner heifner added the OCI Work exclusive to OCI team label Aug 5, 2024
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: INTERNALS
summary: Move block time check in speculative mode above watermark check in production mode.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants