Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IF: Do not advance LIB past HEAD #52

Merged
merged 3 commits into from
Apr 18, 2024
Merged

IF: Do not advance LIB past HEAD #52

merged 3 commits into from
Apr 18, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Apr 18, 2024

It is possible that HEAD is not on the branch that contains the known LIB block. If on a fork, then only advance to our HEAD and only if on the same branch as LIB block. A node in this state should switch forks as it processes blocks allowing it to then advance LIB.

Resolves #46

…n the branch that contains the LIB block. If on a fork, then only advance to our HEAD and only if on the same branch as LIB block.
@heifner heifner added the OCI Work exclusive to OCI team label Apr 18, 2024
@heifner heifner linked an issue Apr 18, 2024 that may be closed by this pull request
@heifner heifner requested review from greg7mdp and linh2931 April 18, 2024 17:10
libraries/chain/fork_database.cpp Outdated Show resolved Hide resolved
@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: INTERNALS
summary: Improve logic during application of a fork, do not advance LIB past HEAD.
Note:end

@heifner heifner merged commit 7a534b5 into savanna Apr 18, 2024
36 checks passed
@heifner heifner deleted the GH-46-lib-advance branch April 18, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Failure: lib_advance_if_test
4 participants