-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to deep-mind log to stderr #732
Conversation
This reverts commit c6589d6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the ability for deepmind to go to stderr seems useful but also seems like a new feature (i.e. not release branch material).
So far I've not seen any evidence that a backed up FILE
buffer can cause this failure. From the testing I've done, when the buffer is full nodeos blocks as expected. Is there a way to reproduce this error just from buffering? The EBADF
errno from the original report also would not immediately suggest a user-space buffering problem to me.
Since deepmind output is, I take it, always expected to be piped to some other process, maybe dmlog_appender should fflush
after each output (or maybe more optimally at some other delineation point). That does seems like a reasonable thing we could add. But lack of that only means that worst case the consumer is a little "behind" the most recent deepmind output.
imo we need more understanding of the issue -- we can't just say deepmind only works properly on stderr instead of stdout.
@spoonincode re-targeted to |
Note:start |
The theory is that #724 is caused by too much buffered output to the pipe. Add ability to write to stderr which is unbuffered.
Add an example
logging.json
that can be used to configure deep-mind to log to stderr.Seems to resolve #724