Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.3] Test failure: p2p_sync_throttle_test #897

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

greg7mdp
Copy link
Contributor

@greg7mdp greg7mdp commented Oct 7, 2024

Resolves #882.

While moving some code around (see here), a call to:

void connection::close(bool reconnect, bool shutdown)

became a call to:

int close(int __fd)

This restores the intended behavior (close the actual connection, instead of closing fd number 1)

@greg7mdp greg7mdp requested review from heifner and linh2931 October 7, 2024 15:04
@greg7mdp greg7mdp changed the base branch from main to release/1.0 October 7, 2024 15:05
@greg7mdp greg7mdp removed the request for review from linh2931 October 7, 2024 15:39
@greg7mdp greg7mdp merged commit 5e32912 into release/1.0 Oct 7, 2024
30 of 36 checks passed
@greg7mdp greg7mdp deleted the gh_882 branch October 7, 2024 15:42
@greg7mdp greg7mdp changed the title [1.0] Test failure: p2p_sync_throttle_test [1.0.3] Test failure: p2p_sync_throttle_test Oct 7, 2024
@arhag arhag added the bug The product is not working as was intended. label Oct 7, 2024
@ericpassmore ericpassmore added the test-instability tag issues for flaky tests, high priority to address label Oct 8, 2024
@ericpassmore
Copy link
Contributor

Note:start
category: System Stability
component: P2P
summary: Fix p2p sync to close connection.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The product is not working as was intended. test-instability tag issues for flaky tests, high priority to address
Projects
None yet
5 participants