Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0.3] Limit apply blocks #921

Merged
merged 5 commits into from
Oct 11, 2024
Merged

[1.0.3] Limit apply blocks #921

merged 5 commits into from
Oct 11, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Oct 10, 2024

  • Interrupt processing of blocks in tight apply block loop.
    • Provides much quicker shutdown during syncing.
    • Allows v1/chain/get_info calls to return quickly during syncing.
  • Restores logging every 1000 blocks during replay.

Resolves #284

@heifner heifner requested review from greg7mdp and linh2931 October 10, 2024 12:05
@heifner heifner added the OCI Work exclusive to OCI team label Oct 10, 2024
@heifner heifner linked an issue Oct 10, 2024 that may be closed by this pull request
Limit apply blocks time in controller #284
Closed
linh2931
linh2931 reviewed Oct 10, 2024
View reviewed changes
libraries/chain/controller.cpp Show resolved Hide resolved
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
libraries/chain/controller.cpp Show resolved Hide resolved
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
linh2931
linh2931 approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@linh2931 linh2931 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this goes to release 1.0, it might be better to have a test to break in the middle of the loop and resume.

@heifner heifner mentioned this pull request Oct 10, 2024
Merged
@heifner heifner merged commit 87079b3 into release/1.0 Oct 11, 2024
36 checks passed
@heifner heifner deleted the GH-284-limit-apply-blocks branch October 11, 2024 18:28
@heifner heifner mentioned this pull request Oct 11, 2024
Merged
@ericpassmore
Copy link
Contributor

Note:start
category: System Stability
component: Internal
summary: Limit Apply Blocks.
Note:end

@arhag arhag linked an issue Nov 7, 2024 that may be closed by this pull request
Upon restart p2p connectback or sync are very hard plus rpc usually timoeut #836
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linh2931 linh2931 linh2931 approved these changes

@greg7mdp greg7mdp greg7mdp approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
4 participants
@heifner @ericpassmore @greg7mdp @linh2931