[1.0.3] Review: Alternative implementation of handling forking #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linh2931
approved these changes
Oct 22, 2024
| } else if (std::holds_alternative<lib_entry_v0>(entry)) { | ||
| auto lib = std::get<lib_entry_v0>(entry).lib; | ||
| if (trx_entries > 0 && lib >= trx_block_num) { | ||
| return trx_block_num; | ||
| if (!trx_block_nums.empty() && lib >= *(--trx_block_nums.end())) { |
There was a problem hiding this comment.
Add a comment saying *(--trx_block_nums.end()) is the highest block number as trx_block_nums is a set of uint32_t.
There was a problem hiding this comment.
Or I can add the comments myself after you merge.
|
|
||
| // initial block forks out | ||
| sp.append(forked_block_trace); | ||
| sp.append(forked_block_trace); // block 1 | ||
| sp.append_trx_ids(forked_block_trxs_entry); // block 1 |
|
Note:start |
heifner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was concerned about the performance of
block_has_trx.Review comments for #966