Include headers in request #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry that was a dumb mistake on my behalf to forget that. this repo's been basically just me using it and it has minimal tests, but maybe more people are using it than myself now soI should increase the health of it. See https://github.com/AnthonyHewins/gotfy/releases/tag/v0.0.10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for making this package.
I self host my own ntfy server with basic auth in front. This requires me to set the
Authorization: Basic <base64-encoded-string>header.I was not able to get this working with
gotfyas-is.The
Publisherstruct exposesHeaderswhich is great as I could set any headers for the request. Unfortunately, theHeadersare not being referenced inSendMessage.This PR adds support for including headers in the request.