Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate warnings from QCommandLineParser (caused by some paritaly implemented features) #189

Closed
pktiuk opened this issue Aug 18, 2021 · 3 comments · Fixed by #1098
Closed
Labels
bug Something isn't working refactor Issues connected with cleaning-up repository

Comments

@pktiuk
Copy link
Member

pktiuk commented Aug 18, 2021

After running antimicrox we get warnings from QCommandLineParser informing about checking not defined options.
These are caused by some partialy implemented features

antimicrox --log-level info
❗WARN  QCommandLineParser: option not defined: "next"
❗WARN  QCommandLineParser: option not defined: "map"
❗WARN  QCommandLineParser: option not defined: "display"

Code adding them to commandline is commented. I don't know why.

        {"display",
            QCoreApplication::translate("main", "Use specified display for
            X11 calls")},
        {"next",
            QCoreApplication::translate("main", "Advance profile loading set
            options")},
         {"map",
             QCoreApplication::translate("main", "Open game controller
             mapping window of selected controller. Value can be
             a controller index or GUID."),
             QCoreApplication::translate("main", "value")},

TODO

Investigate these features and fully enable (finish/fix) them or remove them from code.


Upvote & Fund

  • If you find this issue important, mark it with 👍. It lets us see which fixes and features are demanded by the most users.
  • We're using Polar.sh so you can upvote and help fund this issue. It may incentivize some developers to contribute to this project and fix some bugs.
  • Funded developer receives the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@pktiuk pktiuk added bug Something isn't working refactor Issues connected with cleaning-up repository good first issue Good for newcomers labels Aug 18, 2021
@pktiuk
Copy link
Member Author

pktiuk commented Jan 20, 2022

I think it would be good to just remove these flags with linked code.
These functions are too specific, and nobody was missing them.

@pktiuk
Copy link
Member Author

pktiuk commented Aug 26, 2023

Use case of the --next flag was mentioned in this discussion: #774

@pktiuk
Copy link
Member Author

pktiuk commented Nov 24, 2024

I have no idea what was behind commit e2a35d0 which disabled --next flag. Maybe I could re-enable it and check how it will work

pktiuk added a commit that referenced this issue Nov 24, 2024
Linked issue: #189
Linked discussion: #774
pktiuk added a commit that referenced this issue Dec 8, 2024
Linked issue: #189
Linked discussion: #774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactor Issues connected with cleaning-up repository
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant