Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove empty directories during uninstallation #126

Closed
wants to merge 1 commit into from

Conversation

pktiuk
Copy link
Member

@pktiuk pktiuk commented Dec 19, 2020

Closes #68

Proposed changes

  • delete directories left after antimicrox uninstallation using cmake

@pktiuk pktiuk force-pushed the uninstall-directories branch 2 times, most recently from aab0a95 to 7ff86f4 Compare December 19, 2020 14:26
@pktiuk pktiuk force-pushed the uninstall-directories branch from 7ff86f4 to c4d6a69 Compare December 19, 2020 14:33
@pktiuk
Copy link
Member Author

pktiuk commented Dec 19, 2020

Output during uninstallation in my case

Remaining directories to be deleted: /usr/include/antimicrox;/usr/share/doc/antimicrox;/usr/share/antimicrox

@pktiuk pktiuk requested a review from gombosg December 19, 2020 14:35
Copy link
Collaborator

@gombosg gombosg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok but this looks like a really brute force way. 😆

@pktiuk
Copy link
Member Author

pktiuk commented Dec 21, 2020

@gombosg
Which part of this solution is brute force for you?
Entire deleting directories, or maybe one aspect of implementation?

@gombosg
Copy link
Collaborator

gombosg commented Dec 21, 2020

Nah, it's fine. I don't know what it actually deletes and how it works - it's just cmake magic for me.
E.G. in RPM specfiles, you specify files and directories. If you specify a directory then a package owns it, and make sure that it doesn't delete directories it doesn't own.

If you take a look, it's these for Fedora: https://src.fedoraproject.org/rpms/antimicrox/blob/master/f/antimicrox.spec#_92-107

So the directories you listed are fine, correspond to this one.

@pktiuk
Copy link
Member Author

pktiuk commented Dec 21, 2020

This is just looking for directories with paths ending with antimicrox among directories where antimicrox had files (but not these containing antimicrox anywhere else just in case if someone had installed antimicrox in directories like /home/antimicrox/.local/bin).

I think installing using packages should be a recommended way of installation.
Currently, our build instructions don't contain instructions for building rpm package.

@pktiuk pktiuk closed this Dec 30, 2020
@pktiuk pktiuk deleted the uninstall-directories branch February 20, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The uninstallation leaves several folders and files behind (cmake)
2 participants