Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor arguments parsing #174

Merged
merged 3 commits into from
Jul 10, 2021
Merged

Refactor arguments parsing #174

merged 3 commits into from
Jul 10, 2021

Conversation

pktiuk
Copy link
Member

@pktiuk pktiuk commented Jul 4, 2021 •
edited
Loading

This one is meant to clean up a bit way of parsing arguments

Things do to:

  • Entire parsing process should be done in parsing class (not in main.cpp)
  • Strict checks for arguments (now it is possible to open antimicrox with --profile argument pointing at wrong file)
  • Remove deprecated code used by qt versions older than 5.4.0

@pktiuk pktiuk marked this pull request as draft July 4, 2021 16:04
@pktiuk pktiuk marked this pull request as ready for review July 5, 2021 09:53
@pktiuk pktiuk requested a review from gombosg July 5, 2021 09:53
@pktiuk pktiuk merged commit 039894b into master Jul 10, 2021
@pktiuk pktiuk deleted the refactor_arguments_parsing branch July 10, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gombosg gombosg Awaiting requested review from gombosg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pktiuk