Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix converting hash dictionary to random list. issue #6 #44

Merged
merged 1 commit into from
Sep 17, 2020
Merged

fix: Fix converting hash dictionary to random list. issue #6 #44

merged 1 commit into from
Sep 17, 2020

Conversation

pktiuk
Copy link
Member

@pktiuk pktiuk commented Sep 16, 2020

Closes #6

Fixes

Method QList<T> QHash::values() const was returning list containing sets in random order.

From QHash docs:

Returns a list containing all the values in the hash, in an arbitrary order. If a key is associated with multiple values, all of its values will be in the list, and not just the most recently inserted one.

@pktiuk pktiuk requested a review from gombosg September 16, 2020 21:22
gombosg
gombosg approved these changes Sep 17, 2020
View reviewed changes
Copy link
Collaborator

@gombosg gombosg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL, nice fix!

@gombosg
Copy link
Collaborator

gombosg commented Sep 17, 2020

@pktiuk
I tested, appears to be working correctly.

@pktiuk pktiuk merged commit 61ce55f into master Sep 17, 2020
@pktiuk pktiuk deleted the fix_6 branch September 17, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gombosg gombosg gombosg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong order for setting sets
2 participants
@pktiuk @gombosg