chore(msvc): add msvc cmake support #667
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just two small changes and some
CMakeLists.txt
additions is all it took to build through Visual Studio 2022.C&C welcome!
Proposed changes
/sdl
.QVarLengthArray
since msvc doesn't support all of C99.CMakeLists.txt
, and sets compiler flags that closely match the existing gcc/clang counterparts.BUILDING.md
to elaborate on how to use Visual Studio's built-in cmake support to compile the project.A screenshot quite unlikely needed for this, but I took one anyways 😂
Fixes the msvc warning as error due to
/sdl
.Fixes the msvc warning as error due to/sdl
.Fixes the msvc warning as error due to/sdl
.Fixes the msvc warning as error due to/sdl
.