Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure proper support for breeze icon theme #93

Merged
merged 2 commits into from
Nov 28, 2020
Merged

Conversation

pktiuk
Copy link
Member

@pktiuk pktiuk commented Nov 27, 2020

Closes #66

To check how this change works you can switch to breeze icon theme.

I have tried to make color of this icon similar to default color used by breeze.

@pktiuk
Copy link
Member Author

pktiuk commented Nov 27, 2020

Regular one:

old

Icon for Breeze users:

new

@AriaMoradi
Copy link
Contributor

AriaMoradi commented Nov 27, 2020

well, it might look better on a light background.

Could we see a screenshot comparison with a light theme(background)?

@pktiuk
Copy link
Member Author

pktiuk commented Nov 27, 2020

well, it might look better on a light background.
Could we see a screenshot comparison with a light theme(background)?

Yes, it would definitely look better at brighter background, but I don't know, how to easily change color of top bar in gnome.

I think this screen shows, that it works properly (at least in case of my environment).
This is exactly the same icon, but I have changed only brightness here.

If you want to just see it on the bright background look here:
image

@AriaMoradi
Copy link
Contributor

A dark blueish color might look better

@pktiuk pktiuk merged commit f801789 into master Nov 28, 2020
@pktiuk pktiuk deleted the dark_tray_icon branch November 28, 2020 11:04
Gallxz pushed a commit to Gallxz/antimicrox that referenced this pull request Oct 12, 2023
Gallxz pushed a commit to Gallxz/antimicrox that referenced this pull request Oct 12, 2023
Gallxz pushed a commit to Gallxz/antimicrox that referenced this pull request Oct 12, 2023
Gallxz pushed a commit to Gallxz/antimicrox that referenced this pull request Oct 12, 2023
JoyMix slot holds many other slots
Gallxz pushed a commit to Gallxz/antimicrox that referenced this pull request Oct 12, 2023
Gallxz pushed a commit to Gallxz/antimicrox that referenced this pull request Oct 12, 2023
Gallxz pushed a commit to Gallxz/antimicrox that referenced this pull request Oct 12, 2023
Gallxz pushed a commit to Gallxz/antimicrox that referenced this pull request Oct 12, 2023
Gallxz pushed a commit to Gallxz/antimicrox that referenced this pull request Oct 12, 2023
Gallxz pushed a commit to Gallxz/antimicrox that referenced this pull request Oct 12, 2023
Gallxz pushed a commit to Gallxz/antimicrox that referenced this pull request Oct 12, 2023
Joining many mix slots without complications
Gallxz pushed a commit to Gallxz/antimicrox that referenced this pull request Oct 12, 2023
Click on changed, not saved button with mix slots in main window doesn't crash application
Gallxz pushed a commit to Gallxz/antimicrox that referenced this pull request Oct 12, 2023
tested for combination "A+Z+S+X, Pause, Q" and "A, Z, S, X, Pause, Q" at keyboardchecker.com site
Gallxz pushed a commit to Gallxz/antimicrox that referenced this pull request Oct 12, 2023
tested for combination at keyboardchecker.com site, was looking for memory leaks too
Gallxz pushed a commit to Gallxz/antimicrox that referenced this pull request Oct 12, 2023
for minislots being next to each other
Gallxz pushed a commit to Gallxz/antimicrox that referenced this pull request Oct 12, 2023
However that's debatable
Gallxz pushed a commit to Gallxz/antimicrox that referenced this pull request Oct 12, 2023
Gallxz pushed a commit to Gallxz/antimicrox that referenced this pull request Oct 12, 2023
Gallxz pushed a commit to Gallxz/antimicrox that referenced this pull request Oct 12, 2023
Gallxz pushed a commit to Gallxz/antimicrox that referenced this pull request Oct 12, 2023
Gallxz pushed a commit to Gallxz/antimicrox that referenced this pull request Oct 12, 2023
at the moment it works only after save and refresh
Gallxz pushed a commit to Gallxz/antimicrox that referenced this pull request Oct 12, 2023
Gallxz pushed a commit to Gallxz/antimicrox that referenced this pull request Oct 12, 2023
Gallxz pushed a commit to Gallxz/antimicrox that referenced this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dark tray icon
2 participants