Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Boostrap npm package instead of html scripts #273

Closed
AntonioMrtz opened this issue Oct 29, 2024 · 1 comment · Fixed by #274
Closed

Use Boostrap npm package instead of html scripts #273

AntonioMrtz opened this issue Oct 29, 2024 · 1 comment · Fixed by #274
Assignees
@AntonioMrtz
Labels
frontend Frontend related issues refactor Code changes or improvements that do not change code behaviour

Comments

@AntonioMrtz
Copy link
Owner

Description

Replace boostrap script with npm package

Context

Reduce injected HTML scripts

How to do it

Replace inline script boostrap of html with npm package

Testing

🖐️ Learn how to CONTRIBUTE, all help is welcomed :)

📚 Check out the project documentation for more info

⭐ Help this project grow by giving it a star if you like it!

😵 Trello links are used for traceability, do not ask to join the board before leaving a comment in the related issue
@AntonioMrtz AntonioMrtz added frontend Frontend related issues refactor Code changes or improvements that do not change code behaviour labels Oct 29, 2024
@AntonioMrtz AntonioMrtz self-assigned this Oct 29, 2024
@AntonioMrtz
Copy link
Owner Author

Replace boostrap script with npm package

AntonioMrtz added a commit that referenced this issue Oct 29, 2024
@AntonioMrtz
refactor: use boostrap npm package instead injected html scripts | [#273
465f2a7 
]
@AntonioMrtz AntonioMrtz changed the title Replace boostrap script with npm package Boostrap npm package instead of html scripts Oct 29, 2024
@AntonioMrtz AntonioMrtz changed the title Boostrap npm package instead of html scripts Use Boostrap npm package instead of html scripts Oct 29, 2024
@AntonioMrtz AntonioMrtz mentioned this issue Oct 29, 2024
Merged
@AntonioMrtz AntonioMrtz linked a pull request Oct 29, 2024 that will close this issue
#273: Use Boostrap npm package instead of html scripts #274
Merged
AntonioMrtz added a commit that referenced this issue Nov 1, 2024
@AntonioMrtz
fix: edit playlist breaking on boostrap changes | [#273]
f7f8396
AntonioMrtz added a commit that referenced this issue Nov 1, 2024
@AntonioMrtz
chore: minor docs update | [#273]
5a7873c
AntonioMrtz added a commit that referenced this issue Nov 1, 2024
@AntonioMrtz
refactor: replace boostrap script with npm package + improve edit Pla…
043571b 
…ylist form | [#273]

* refactor: use boostrap npm package instead injected html scripts | [#273]

* fix: boostrap dependecy error pipelines 2.0.0

npm warn deprecated boostrap@2.0.0: Package no longer supported. Contact support@npmjs.com for more info.

* fix: edit playlist breaking on boostrap changes | [#273]

* chore: minor docs update | [#273]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AntonioMrtz AntonioMrtz

Labels
frontend Frontend related issues refactor Code changes or improvements that do not change code behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#273: Use Boostrap npm package instead of html scripts AntonioMrtz/SpotifyElectron
1 participant
@AntonioMrtz