-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Health endpoint #140
Add Health endpoint #140
Conversation
…leware and login router datetime.utcnow deprecation
This PR replaces #139 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, first of all thanks for contributing to the project and taking the time to solve all the issues you had with the setup.
Its recommend in PRs that the only changes included should be related to the issue. Some changes are out of scope:
- Imports re-formatting and changing alias
- Non related files changes such as .env.example, docker scripts
The overall PR is really good, the health endpoint was correct, tests were good and health endpoint was added into middleware bypass paths.
For the PR to be approve we have to fix the changes that were out of this scope for this PR. I will review them when there finished.
Once more, thanks for your work. If you have any question related to the project or the review just ask me. The PR is good and only minor changes have to be made. Thanks for your time :)
@AntonioMrtz thanks for the feedback, I'll try to make the changes suggested ASAP. The import changes for those files you mentioned happened after running the style and linting on the code. I wasn't sure whether to revert it or not at the time |
@AntonioMrtz I made your suggested changes. I used the |
Hi, using --no-verify flag its a good solution. I will try to have the refactored version ASAP. This will make the overall development easier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rollback UTC changes :)
Once youre finished, can you update the PR description with the final changes? Thanks in advance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing. Good PR, i hope it helped you understand how is our workflow and motivates you to keep contributing to the project. There are some issues both for backend and frontend and when i have time i will publish more that i have stored on Trello. I hope your contributing experience was great. If it seems good to you i would be eager to see more of your work in the project. This issue shouldnt take long, take a look if u want. Thanks again and i hope to see you working on the project soon, I will add your github profile to the contributors lists. Regards :)
Description
This pull request introduces the addition of a health endpoint along with related tests. It also includes modifications to the authentication middleware so that the health endpoint is bypassed.
Commit type
feat
: indicates the addition of a new feature or functionality to the project.Issue
Create health endpoint #134
Solution
The health endpoint is added to provide a health check for the application, which can be useful for monitoring purposes. The modifications to bypass authentication for the health endpoint keeps it simple and accessible.
Proposed Changes
-Added health endpoint router and related tests
-Included health router in
__main__.py
-Modified authentication middleware to bypass authentication for health endpoint
-Utilized Starlette's named constants for status codes
Potential Impact
These changes are expected to have a positive impact on the project by enhancing its monitoring capabilities.
Tests Performed
Additional Tasks
-Review and address any feedback received during the pull request review process
Assigned
@AntonioMrtz