#261: Improve Cold Start requests by adding timeout and blocking user input

[gigigimay]

Description

Improve Cold Start requests by adding timeout and blocking user input in login and register page

Commit type

• feat: indicates the addition of a new feature or functionality to the project.

Issue

#261

Solution

Proposed Changes

I made these changes in these requests: login, auto login, register:

• show loading circle and disable form inputs and buttons
• handle login + auto login + register request timeout by showing an error popup and cancelling the http request
• the cold start timeout duration (5 seconds) was also moved to global config

Potential Impact

--

Screenshots

(in the screen record, I changed the timeout to 2 secs to make it faster)

Additional Tasks

--

Assigned

@AntonioMrtz

[AntonioMrtz]

Hi @gigigimay , thanks for your time. I will review this PR ASAP :). I runned the pipelines and saw ESlint Check / run-frontend-lint failing, can you take a look?

[gigigimay]

Thanks, I have fixed the failed lint.

[AntonioMrtz]

Can we have tests that validate the new feature behaviour?

[gigigimay]

Unit tests added. It would be easier to review while ignoring white-spaces since I wrapped all the tests in RegisterMenu.test.tsx into a describe function.

[gigigimay]

Hi @AntonioMrtz , All the requested changes were done. (Unit tests and moving loading into the buttons) Please let me know if there's anything else I should change. :)

[AntonioMrtz]

Only this little adjustment :). Code looks nice, this has to be one of the best PRs I have received in the project, I enjoyed checking and testing the changes as well as the implementation. Don't worry about the pipeline, the failing one has a dependency on a enviroment variable provided to the github repo, I will get it solve soon

[gigigimay]

@AntonioMrtz I'm glad you enjoyed reviewing my PR. I'm participating in the Hacktoberfest event, and for this PR to count, could you please label it as 'hacktoberfest-accepted' or add the 'hacktoberfest' topic to this repository? You can find more details about the rules here: https://hacktoberfest.com/participation/. Thank you very much! :)

[AntonioMrtz]

@AntonioMrtz I'm glad you enjoyed reviewing my PR. I'm participating in the Hacktoberfest event, and for this PR to count, could you please label it as 'hacktoberfest-accepted' or add the 'hacktoberfest' topic to this repository? You can find more details about the rules here: https://hacktoberfest.com/participation/. Thank you very much! :)

Yeah, I was planning on adding the hacktoberfest-accepted tag :). I hope you enjoyed your experience colaborating in our project, there's also more open issues with the hacktoberfest tag in the repo, take a look at them if you we're thinking about contributing :). Let my know if you need anything