Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use cpp11 and cpp11 only #1

Merged
merged 2 commits into from
Jan 30, 2023
Merged

use cpp11 and cpp11 only #1

merged 2 commits into from
Jan 30, 2023

Conversation

pachadotdev
Copy link

hi @Antonov548 @krlmlr

I made some changes after my big adventure converting fixest into fixest2

2 notes atm

❯ checking installed package size ... NOTE
    installed size is  5.8Mb
    sub-directories of 1Mb or more:
      libs   5.3Mb

❯ checking top-level files ... NOTE
    possible bashism in configure line 21 ('command' with option other than -p):
    if [ `uname` = "Darwin" ] && [ `command -v pkg-config` ]; then
    possible bashism in configure line 38 ('command' with option other than -p):
    if [ -z "$FORCE_AUTOBREW" ] && [ `command -v pkg-config` ]; then
    possible bashism in configure line 58 ('command' with option other than -p):
    if [ -z "$FORCE_AUTOBREW" ] && [ `command -v pg_config` ]; then

0 errors ✔ | 0 warnings ✔ | 2 notes ✖

I also tested by hand (remember databases.pacha.dev?) for v1.4.5.9003

> library(dplyr)
> library(RPostgres)
> 
> con <- dbConnect(
+   Postgres(),
+   user = Sys.getenv("dbedu_usr"),
+   password = Sys.getenv("dbedu_pwd"),
+   dbname = "financial",
+   host = "databases.pacha.dev"
+ )
> 
> dbListTables(con)
[1] "accounts"  "cards"     "clients"   "disps"     "districts" "loans"     "orders"    "tkeys"    
[9] "trans"    
> 
> tbl(con, "clients") %>% glimpse()
Rows: ??
Columns: 4
Database: postgres  [teacher@databases.pacha.dev:5432/financial]
$ id           <int64> 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 2…
$ birth_number <chr> "706213    ", "450204    ", "406009    ", "561201    ", "605703    ", "190922    ", "2…
$ district_id  <int64> 18, 1, 1, 5, 5, 12, 15, 51, 60, 57, 57, 40, 54, 76, 21, 21, 76, 76, 47, 46, 12, 1, 1…
$ tkey_id      <int64> NA, 21, 21, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, …
> 
> dbDisconnect(con)

@Antonov548
Copy link
Owner

Antonov548 commented Jan 30, 2023

hi @Antonov548 @krlmlr

I made some changes after my big adventure converting fixest into fixest2

2 notes atm

❯ checking installed package size ... NOTE
    installed size is  5.8Mb
    sub-directories of 1Mb or more:
      libs   5.3Mb

❯ checking top-level files ... NOTE
    possible bashism in configure line 21 ('command' with option other than -p):
    if [ `uname` = "Darwin" ] && [ `command -v pkg-config` ]; then
    possible bashism in configure line 38 ('command' with option other than -p):
    if [ -z "$FORCE_AUTOBREW" ] && [ `command -v pkg-config` ]; then
    possible bashism in configure line 58 ('command' with option other than -p):
    if [ -z "$FORCE_AUTOBREW" ] && [ `command -v pg_config` ]; then

0 errors ✔ | 0 warnings ✔ | 2 notes ✖

I also tested by hand (remember databases.pacha.dev?) for v1.4.5.9003

> library(dplyr)
> library(RPostgres)
> 
> con <- dbConnect(
+   Postgres(),
+   user = Sys.getenv("dbedu_usr"),
+   password = Sys.getenv("dbedu_pwd"),
+   dbname = "financial",
+   host = "databases.pacha.dev"
+ )
> 
> dbListTables(con)
[1] "accounts"  "cards"     "clients"   "disps"     "districts" "loans"     "orders"    "tkeys"    
[9] "trans"    
> 
> tbl(con, "clients") %>% glimpse()
Rows: ??
Columns: 4
Database: postgres  [teacher@databases.pacha.dev:5432/financial]
$ id           <int64> 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 2…
$ birth_number <chr> "706213    ", "450204    ", "406009    ", "561201    ", "605703    ", "190922    ", "2…
$ district_id  <int64> 18, 1, 1, 5, 5, 12, 15, 51, 60, 57, 57, 40, 54, 76, 21, 21, 76, 76, 47, 46, 12, 1, 1…
$ tkey_id      <int64> NA, 21, 21, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, …
> 
> dbDisconnect(con)

thanks @pachadotdev
vscode-install.r file - is it something utilitarian?

@Antonov548 Antonov548 merged commit 718db2c into Antonov548:cpp11 Jan 30, 2023
@pachadotdev
Copy link
Author

@Antonov548 yes! the vscode is a help file because ctrl+shift+b doesn't work with vscode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants