Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to the latest openssl #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

alex
Copy link

@alex alex commented Jan 5, 2019

The version of openssl that was previously used had numerous security issues, and did not support the latest versions of the upstream openssl package.

I wasn't sure what to do about the impl Clone on connection, there doesn't appear to be a way to get the current behavior with SslStream in the latest version of openssl.

The version of openssl that was previously used had numerous security issues, and did not support the latest versions of the upstream openssl package.
@Shnatsel
Copy link

Shnatsel commented Jan 5, 2019

Relevant to #58

@dizda
Copy link

dizda commented Jan 15, 2019

LGTM 👍

@Antti
Copy link
Owner

Antti commented Jan 24, 2019

This doesn't really upgrade to the latest openssl, as adding panic makes it TLS mode completely non-functional.
I removed tls feature from the list of default features, this should make it easier to use this crate when the tls (openssl) feature is not required.

@alex
Copy link
Author

alex commented Jan 24, 2019

Hmm, unfortunately I don't believe it's possible to emulate the Clone API with a recent OpenSSL, except perhaps by making it an Rc (or maybe Arc or Mutex + Arc). Do you have an opinion on how to proceed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants