Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD Show diff between the expected output and the actual output in the autograder #325

Merged
merged 0 commits into from
Jan 16, 2022

Conversation

PIG208
Copy link
Contributor

@PIG208 PIG208 commented Dec 18, 2021

The plan is to add a column called diff to SubmissionTestResult, which is usually None.

I'm adding a column instead of a special directive that can be parsed when it shows up in stdout. Because we will have to implement and maintain an extra parser in the frontend, while having a separate field allows us to feed it to react-diff-view directly.

Fixes #254

@PIG208 PIG208 marked this pull request as draft December 18, 2021 23:25
@wabscale
Copy link
Collaborator

Hey you should hold off on this. This is going to be a piece of much larger changes to the way that autograding happens. We're going to be doing this during winter break.

@PIG208
Copy link
Contributor Author

PIG208 commented Dec 19, 2021

I will do a quick push tmr to kind of see how this turns out.

@PIG208
Copy link
Contributor Author

PIG208 commented Dec 19, 2021

OK, it seems to be a bit more complicated than I expected. Because now I'm trying to set up test cases before actually making the changes. So it might take longer.

@PIG208 PIG208 force-pushed the diff-view branch 7 times, most recently from d80db5b to 29cf6e4 Compare December 25, 2021 07:59
@PIG208 PIG208 force-pushed the diff-view branch 4 times, most recently from e4e0b9d to 6070509 Compare January 1, 2022 05:15
@PIG208
Copy link
Contributor Author

PIG208 commented Jan 1, 2022

image
image
image

@PIG208 PIG208 force-pushed the diff-view branch 2 times, most recently from ea03ebb to 7242901 Compare January 2, 2022 02:13
@PIG208 PIG208 force-pushed the diff-view branch 2 times, most recently from 1f8a470 to 79e6b86 Compare January 14, 2022 05:36
@PIG208 PIG208 marked this pull request as ready for review January 14, 2022 05:37
@PIG208 PIG208 force-pushed the diff-view branch 2 times, most recently from b111caf to 36a4299 Compare January 14, 2022 05:38
@PIG208
Copy link
Contributor Author

PIG208 commented Jan 14, 2022

I just updated the PR. Specifically, I reworked test_lines in bf3f1e5. Previously we just preprocess all the lines and compute the diff of the entire outputs. This improves the performance by only parsing the diff within a limited context where we have the first mismatch.

@wabscale
Copy link
Collaborator

I'm going to get on later and push some changes before rebasing this. I need to adjust a few things so that it will fit into the changes to the autograde tests format.

@PIG208 PIG208 changed the title [WIP] ADD Show diff between the expected output and the actual output in the autograder ADD Show diff between the expected output and the actual output in the autograder Jan 14, 2022
wabscale added a commit that referenced this pull request Jan 16, 2022
@wabscale wabscale merged commit 36a4299 into AnubisLMS:master Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ADD Show diff between the expected output and the actual output in the autograder
2 participants