Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make home page responsive and fix nav bar #65

Merged
merged 3 commits into from
Jan 27, 2024

Conversation

monoMonu
Copy link
Contributor

Pull Request

Related Issues:
[List any related issues or reference them using the syntax #issue_number.]

Fixes #10 #32 #50

Description:

  • Made the home page responsive for various devices(including Mobile)
  • Modified Nav Bar and made responsive, Added Hamburger nav bar for small devices
  • Remove unnecessary code from corresponding files

Note: Do [x] to select the below checkbox

Checklist:

  • I have tested my changes.
  • My code follows the project's coding standards.
  • I have updated the documentation (if applicable).

Screenshots:
Screenshot 2024-01-24 234446
Screenshot 2024-01-24 234603
Screenshot 2024-01-24 234915

Additional information

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @monoMonu! 🎉 Thank you for submitting your pull request for MealMatters. Our dedicated team will review it diligently.Your contribution is valuable and we appreciate your efforts to improve our project.

Copy link
Owner

@AnupK1234 AnupK1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly change the onhover color of navbar element.

@monoMonu
Copy link
Contributor Author

Kindly change the onhover color of navbar element.

Into which color ?

@AnupK1234
Copy link
Owner

Kindly change the onhover color of navbar element.

Into which color ?

Keep it black.

@monoMonu
Copy link
Contributor Author

I have made the changes as requested.
@AnupK1234 please review the PR

and please let me know why I am getting "PR title checker error" ?

@monoMonu monoMonu requested a review from AnupK1234 January 26, 2024 11:42
Copy link

gitguardian bot commented Jan 27, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
- Generic Password 6ed32cc server/tests/integration/auth.test.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@AnupK1234 AnupK1234 added Ready to merge PR ready to merge Accepted PR accepted and removed title needs formatting labels Jan 27, 2024
@AnupK1234 AnupK1234 merged commit afaaf02 into AnupK1234:main Jan 27, 2024
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Making homepage responsive
2 participants