Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #76 : Remove the dropdown from Homepage #78

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

MohitKambli
Copy link
Contributor

Pull Request

Fixes #76

Description:
Hello.
Hope you're doing well.
Since this issue is regarding the client side, I simply configured the client folder on my machine and implemented the necessary changes. I have made the code changes in client\src\components\Navbar.jsx file, wherein I have simply eliminated the list view that had the select tags responsible for displaying the dropdown menu.
Now, the landing page looks as mentioned in the screenshots section below.
Hope the mentioned code changes meet the necessary requirement.
If at all there are any problems regarding the implemented code changes, then do let me know.
Sincere apologies if I made any mistakes while solving this issue.

Note: Do [x] to select the below checkbox

Checklist:

  • I have tested my changes.
  • My code follows the project's coding standards.
  • I have updated the documentation (if applicable).

Screenshots:
image

Additional information

Please provide any other information that you think may be relevant to the pull request.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @MohitKambli! 🎉 Thank you for submitting your pull request for MealMatters. Our dedicated team will review it diligently.Your contribution is valuable and we appreciate your efforts to improve our project.

@AnupK1234
Copy link
Owner

The issue is not assigned to you ?

@MohitKambli
Copy link
Contributor Author

No, @AnupK1234. It hasn't been assigned to me yet.

@AnupK1234
Copy link
Owner

AnupK1234 commented Feb 11, 2024

Kindly do not create a PR unless the issue is assigned to you. If you wish to work on a issue do let me know in the comments of that issue. I will assign it to you

@MohitKambli
Copy link
Contributor Author

Hello @AnupK1234
Sincere apologies for not getting it assigned first and then creating a PR.
I will make sure not to make this mistake again in the future.
If at all there's anything that I can do to redeem myself, then please let me know.
Once again, I am deeply sorry for this step taken.

@AnupK1234
Copy link
Owner

Drop a comment on the issue. I will assign it to you.

@MohitKambli
Copy link
Contributor Author

Please assign this issue to me.

@AnupK1234 AnupK1234 merged commit 68ac4d9 into AnupK1234:main Feb 16, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the dropdown from Homepage
2 participants