feat: snapshotting using geth local provider [APE-739] #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotPeopling2day
changed the title
APE-739 "test: geth now has snapshotting" (ApeWorX/ape #1349)
What I didethereum/go-ethereum#26154 was resolved as of geth v1.11.0 release How I did itRemove the skip, see if it passes How to verify itIt passes. Also, probably do some QA on the feature w/ geth Checklist
ApeWorX/ape #1349 by fubuloubu on GitHub via LinearSync |
|
A new py-geth with this change is required: ethereum/py-geth#138 |
antazoey
reviewed
Mar 24, 2023
antazoey
changed the title
antazoey
changed the title
antazoey
approved these changes
Mar 24, 2023
|
@fubuloubu can merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
ethereum/go-ethereum#26154 was resolved as of geth v1.11.0 release
How I did it
Remove the skip, see if it passes
How to verify it
It passes. Also, probably do some QA on the feature w/ geth
Checklist
- [ ] New test cases have been added- [ ] Documentation has been updated