Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brownie Account Support #4

Closed
4 tasks done
ShadeUndertree opened this issue May 24, 2021 · 2 comments
Closed
4 tasks done

Brownie Account Support #4

ShadeUndertree opened this issue May 24, 2021 · 2 comments
Assignees

Comments

@ShadeUndertree
Copy link

ShadeUndertree commented May 24, 2021

Elevator pitch:

Integrate eip712 into brownie's local account class so that Brownie accounts can sign eip712 messages.

Value:

The first place we're going to use this in yearn-vaults, to get rid of the dependency on eth-account in the test suite. Example:

https://github.com/yearn/yearn-vaults/blob/67cf46f3/tests/conftest.py#L91-L139

Other than that, this will be a useful feature for end users of Brownie.

Dependencies:

None.

Design approach:

Design is all set. See the task list.

Task list:

  • Copy whatever code is needed from eth_account to implement the account signing logic
  • Use the eip712 package in brownie to implement sign_message on e.g. the _PrivateKeyAccount class
  • Write new tests for eip712 and brownie using the new code
  • Submit PR to brownie for adding the eip712 dependency and using eip712 to implement sign_message

Estimated completion date:

2021-05-26.

Design review:

Do not signoff unless: 1) agreed the tasks and design approach will achieve acceptance and 2) the work can be completed by one person within the SLA. Design reviewers should consider simpler approaches to achieve goals.

(Please leave a comment to sign off)

@fubuloubu fubuloubu changed the title EIP-712 & Brownie Account Support Brownie Account Support May 24, 2021
@lost-theory lost-theory self-assigned this May 24, 2021
@fubuloubu
Copy link
Member

LGTM

lost-theory added a commit that referenced this issue May 26, 2021
Adding an issue template based on our experience with #4.
@lost-theory
Copy link
Contributor

This was finished on Jul 1st.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants