Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Certain fields in EIP712Message and EIP712Type might conflict with downstream usecases #9

Closed
fubuloubu opened this issue Nov 2, 2021 · 0 comments · Fixed by #29
Closed

Certain fields in EIP712Message and EIP712Type might conflict with downstream usecases #9

fubuloubu opened this issue Nov 2, 2021 · 0 comments · Fixed by #29
Labels
bug Something isn't working
Milestone
v0.2.0

Comments

@fubuloubu
Copy link
Member

Example: this messes with Gnosis Safe signatures which uses data as a field

eip712/eip712/messages.py

Line 118 in 68f5ebb

def data(self) -> dict:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging a pull request may close this issue.

refactor!: reduce name conflicts ApeWorX/eip712
1 participant
@fubuloubu