feat: expose safe tx eip712 structured data #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uxio0
requested changes
Nov 3, 2021
There was a problem hiding this comment.
Good PR! I'm also thinking on migrating to the newer library eip712_structs that I'm using for the Gnosis Protocol: https://github.com/gnosis/gnosis-py/blob/master/gnosis/protocol/order.py
banteg
added a commit
to banteg/brownie-safe
that referenced
this pull request
Nov 3, 2021
|
There is also a good library called eip712, but I found a name clash bug in it when trying to implement the struct used here. |
Uxio0
approved these changes
Nov 4, 2021
banteg
added a commit
to banteg/brownie-safe
that referenced
this pull request
Nov 10, 2021
* feat: backport gnosis-py safe_tx_data safe-global/safe-eth-py#120 * feat: sign with frame * fix: no eip-155 support in ledger signatures * docs: add singing and useful links sections * chore: bump version and requirements * chore: bump gnosis-py min required version * refactor: remove backported eip712 code as * feat: submit signature * feat: reconstruct safe tx from api * fix: confirmations * feat: retrieve pending txs from tx service * docs: update signing docs * feat: add tx execution * docs: update detailed example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose the EIP712 structured data of a SafeTx as
safe_tx_data(extracted fromsafe_tx_hash).This structure could be useful elsewhere, ranging from third-party signing to verification purposes.
My use case is passing it to Frame for signing.