Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dereference blog post #70

Merged
merged 10 commits into from
May 22, 2024
Merged

Conversation

carlesarnal
Copy link
Member

No description provided.

Copy link
Member

@paoloantinori paoloantinori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spotted a typo

_posts/2024-05-14-registry-dereference.md Outdated Show resolved Hide resolved
Copy link
Member

@EricWittmann EricWittmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably needs a little bit of copy editing to tweak some sentences here and there, but overall looks good. I have a few comments/questions, but I would suggest we merge and then iterate in future PRs if we want.

@carlesarnal
Copy link
Member Author

Probably needs a little bit of copy editing to tweak some sentences here and there, but overall looks good. I have a few comments/questions, but I would suggest we merge and then iterate in future PRs if we want.

I have addressed the first round. @pwright all yours to change whatever you consider (and feel free to ask any questions, of course).

Copy link
Contributor

@pwright pwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestions

_posts/2024-05-14-registry-dereference.md Outdated Show resolved Hide resolved
_posts/2024-05-14-registry-dereference.md Outdated Show resolved Hide resolved
_posts/2024-05-14-registry-dereference.md Outdated Show resolved Hide resolved
_posts/2024-05-14-registry-dereference.md Outdated Show resolved Hide resolved
_posts/2024-05-14-registry-dereference.md Outdated Show resolved Hide resolved
_posts/2024-05-14-registry-dereference.md Outdated Show resolved Hide resolved
_posts/2024-05-14-registry-dereference.md Show resolved Hide resolved
_posts/2024-05-14-registry-dereference.md Show resolved Hide resolved
_posts/2024-05-14-registry-dereference.md Outdated Show resolved Hide resolved
carlesarnal and others added 7 commits May 22, 2024 10:46
Co-authored-by: Paul Wright <5154224+pwright@users.noreply.github.com>
Co-authored-by: Paul Wright <5154224+pwright@users.noreply.github.com>
Co-authored-by: Paul Wright <5154224+pwright@users.noreply.github.com>
Co-authored-by: Paul Wright <5154224+pwright@users.noreply.github.com>
Co-authored-by: Paul Wright <5154224+pwright@users.noreply.github.com>
Co-authored-by: Paul Wright <5154224+pwright@users.noreply.github.com>
@carlesarnal carlesarnal merged commit 06936fe into Apicurio:main May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants