#225 Apipie not supporting documentation bootstrapping for controllers outside /app #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, should https://github.com/Apipie/apipie-rails/pull/227/files#diff-6876711862c5edf0c4dfed417bbe3095R41 really be '=' ? |
|
Yes, it's just extracting the value into a variable, not comparing on equality |
| @@ -30,6 +30,12 @@ | |||
| # for reloading to work properly you need to specify where your api controllers are (like in Dir.glob): | |||
| config.api_controllers_matcher = File.join(Rails.root, "app", "controllers", "**","*.rb") | |||
|
|
|||
| # specify if your api controllers located outside of /app/controllers folder. Used for bootstrapping. | |||
| config.base_controllers_path = File.join(Rails.root, "app", "controllers") | |||
There was a problem hiding this comment.
I wonder if the api_controllers_matcher could not be used for this setting. Is there any reason we need special setting for that?
|
Thanks for the patch, one comment in the code |
…rollers outside /app Some refactoring
|
Fixed. Now application search generated controller name in array from api_controllers_matcher |
|
Merging, thanks! |
iNecas
added a commit
that referenced
this pull request
Mar 18, 2014
#225 Apipie not supporting documentation bootstrapping for controllers outside /app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#225 Apipie not supporting documentation bootstrapping for controllers outside /app
Plus:
Some refactoring