Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add viewport meta tag. #412

Merged
merged 1 commit into from
Dec 13, 2015
Merged

Add viewport meta tag. #412

merged 1 commit into from
Dec 13, 2015

Conversation

buren
Copy link
Contributor

@buren buren commented Dec 13, 2015

Thanks for an awesome gem 👍

I just added a viewport meta tag to make the documentation easier to read on mobile devices.

Before

before

After

after

Tested on Android chrome (and chrome/safari/firefox on desktop).

Thanks again :)

Improves the layout on mobile devices.

Meta tag description:
https://developer.mozilla.org/en-US/docs/Mozilla/Mobile/Viewport_meta_tag.
Pajk added a commit that referenced this pull request Dec 13, 2015
@Pajk Pajk merged commit 31964ce into Apipie:master Dec 13, 2015
@Pajk
Copy link
Member

Pajk commented Dec 13, 2015

@buren thanks! Tested on tablet and it's definitely more readable. Still not very nice on a phone but I guess it would need more changes to make it really mobile friendly.

@buren
Copy link
Contributor Author

buren commented Dec 13, 2015

Yeah, I was meaning to ask. Do you have a plan for the design? I'm using apipie in a new project, quite extensively, and will probably look into making the docs more mobile friendly, please let me know if there is anything I can do to help.

Thanks again for an awesome project, its been a breeze setting up :) ⭐

@buren buren deleted the viewport-meta-tag branch December 13, 2015 21:50
@Pajk
Copy link
Member

Pajk commented Dec 14, 2015

All thanks should go to @iNecas who has been maintaining Apipie for more than 3 years and of course the community is doing great job too.

AFAIK there are no plans for redesign. I think most of the ppl are using their own design but it would be nice to have something better looking as a default.

@iNecas
Copy link
Member

iNecas commented Feb 18, 2016

v0.3.6 with this change has just been released. Thanks @buren

@buren
Copy link
Contributor Author

buren commented Feb 18, 2016

Thank you @iNecas :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants