Throw a warning if only the IGNORE field is mismatched #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nix-apollo
reviewed
Dec 7, 2023
| f"Buffer {seq_param_name} does not match between seq_model and tlens_model" | ||
| ) | ||
| if seq_param_name.endswith("IGNORE"): | ||
| print( |
There was a problem hiding this comment.
Please make this a warnings.warn call.
There was a problem hiding this comment.
Ideally would fix here too :)
Line 129 in 7ac5fec
|
Implemented logging as requested on Slack, see here for screenshots. |
stefan-apollo
changed the title
nix-apollo
added a commit
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only throw a warning if the IGNORE field is mismatched, instead of raising an error.
Description
Allows loading transformers that use a different causal masking strategy (-1e5 rather than -inf). Useful for loading models before the convention change if they don't break with -1e5 (such as mod add models). Should not be used for Pythia.
Prints a warning whenever this occurs.
Motivation and Context
I sometimes need to load old mod add models, want to be able to reproduce results. Backwards compatibility.
How Has This Been Tested?
I can load models now; I checked that mod add does not have large attention scores.
Does this PR introduce a breaking change?
No