Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'model' key when parsing interaction_graph_info #262

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Remove 'model' key when parsing interaction_graph_info #262

merged 2 commits into from
Dec 19, 2023

Conversation

danbraunai-apollo
Copy link
Contributor

@danbraunai-apollo danbraunai-apollo commented Dec 18, 2023 •
edited
Loading

Remove 'model' key when parsing interaction_graph_info

Description

  • Fixes the incorrect key in the model_config_dict in run_mlp_ablations.py. Assumes both lms and mlps store the pure model config (and no other info such as train info) in their results. See discussion in MLP rib build -> ablation pipeline is broken. #259.
  • Creates a new sample graph (which will store just the model config inside model_config_dict. This should have been done in Implement ModularDNN model #235 when this breaking change was introduced.

Related Issue

Closes #259

Does this PR introduce a breaking change?

Yes. Well, it fixes the earlier breaking change.

@danbraunai-apollo danbraunai-apollo merged commit 33a3f5f into main Dec 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nix-apollo nix-apollo nix-apollo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MLP rib build -> ablation pipeline is broken.
2 participants
@danbraunai-apollo @nix-apollo