Block communication in client class when rate limited #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable and a good way to make sure that the moving window doesn't keep advancing due to over-eager retry heuristics. +1 from me! |
jacoscaz
approved these changes
Jul 6, 2024
jacoscaz
reviewed
Jul 7, 2024
JeroenVdb
added a commit
to JeroenVdb/daikin-controller-cloud
that referenced
this pull request
Aug 4, 2024
* origin/main: (21 commits) build(deps-dev): bump @alcalzone/release-script from 3.7.0 to 3.8.0 (Apollon77#153) build(deps-dev): bump typescript from 5.5.3 to 5.5.4 (Apollon77#151) chore: release v2.4.0 Allows to ignore the check if a state is writable on setData chore: release v2.3.0 Block API request maximum for 24h and then check again (Apollon77#149) binds to the port provided by the OS if none is provided via config, defaults to 0.0.0.0 as the bind address if none is provided in the config, constructs the redirectUri based bind address and port if none is provided via config (Apollon77#148) chore: release v2.2.0 Block communication in client class when rate limited (Apollon77#147) enhance docs chore: release v2.1.1 * Expose the Rate limit error retryAfter time in the error object chore: release v2.1.0 * Expose the Rate limit error retryAfter time in the error object chore: release v2.0.0 docs chore: release v2.0.0-alpha.9 minimum nodejs 18.2 chore: release v2.0.0-alpha.8 release ... # Conflicts: # .gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.