Distributed cache v2 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2 for the project targeting .net standard 2.0 and ensure all tests compile and pass.
…r caching projects.
…e. Also, update the release notes for v1.0.0. Finally, updatethe changelog.md file.
…ions caching package rather than memory.
| @@ -1,4 +1,8 @@ | |||
| # Polly.Caching.IDistributedCache change log | |||
| # Polly.Caching.Distributed change log | |||
| ## 1.0.0 | |||
There was a problem hiding this comment.
Need to make this
## 2.0.0
as a version 1.0.x of this package has already been released.
| @@ -13,6 +13,12 @@ | |||
| <tags>Polly Cache Caching Cache-aside</tags> | |||
| <copyright>Copyright © 2017, App vNext</copyright> | |||
| <releaseNotes> | |||
| 1.0.0 | |||
There was a problem hiding this comment.
Need to make this 2.0.0 as a version 1.0.x of this package has already been released.
reisenberger
previously requested changes
May 27, 2018
There was a problem hiding this comment.
@SeanFarrow This PR is looking great! Could you:
- bump the version to 2.0.0 in GitVersionConfig.yaml and re-run the build (that'll bump the version to 2.0.0 in places like AssemblyInfo.cs too; only ChangeLog.md and the nuspec will also need adjusting manually to 2.0.0)
- retarget the PR against the v20dev branch? Then I'll merge and make some minor updates to the readme/doco before merging to master.
Thanks!
|
@SeanFarrow I've changed the base branch of PR 👍 I'll fix up the v2.0.0 refs and merge soon! |
This was referenced May 27, 2018
reisenberger
dismissed
their stale review
@reisenberger will implement points listed in review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the distributed cache to support .net standard 2.0 and use Polly V6.0.1. Also update the build process and namespaces to conform to the style used in other repositories. Finally, update the Microsoft caching packages where required.