Refactor circuit breaker exception constructor tests.

App-vNext · Oct 4, 2024 · a40283d · a40283d
1 parent 29f6e84
commit a40283d
Show file tree

Hide file tree

Showing 2 changed files with 72 additions and 33 deletions.
diff --git a/test/Polly.Core.Tests/CircuitBreaker/BrokenCircuitExceptionTests.cs b/test/Polly.Core.Tests/CircuitBreaker/BrokenCircuitExceptionTests.cs
@@ -5,34 +5,61 @@ namespace Polly.Core.Tests.CircuitBreaker;
 public class BrokenCircuitExceptionTests
 {
     [Fact]
-    public void Ctor_Ok()
+    public void Ctor_Default_Ok()
     {
-        var retryAfter = new TimeSpan(1, 0, 0);
-        var defaultException = new BrokenCircuitException();
-        defaultException.Message.Should().Be("The circuit is now open and is not allowing calls.");
-        defaultException.RetryAfter.Should().BeNull();
-        var retryAfterException = new BrokenCircuitException(retryAfter);
-        retryAfterException.Message.Should().Be($"The circuit is now open and is not allowing calls. It can be retried after '{retryAfter}'.");
-        retryAfterException.RetryAfter.Should().Be(retryAfter);
-        var dummyMessageException = new BrokenCircuitException("Dummy.");
-        dummyMessageException.Message.Should().Be("Dummy.");
-        dummyMessageException.RetryAfter.Should().BeNull();
-        var dummyMessageWithRetryAfterException = new BrokenCircuitException("Dummy.", retryAfter);
-        dummyMessageWithRetryAfterException.Message.Should().Be("Dummy.");
-        dummyMessageWithRetryAfterException.RetryAfter.Should().Be(retryAfter);
-        var dummyMessageExceptionWithInnerException = new BrokenCircuitException("Dummy.", new InvalidOperationException());
-        dummyMessageExceptionWithInnerException.Message.Should().Be("Dummy.");
-        dummyMessageExceptionWithInnerException.InnerException.Should().BeOfType<InvalidOperationException>();
-        dummyMessageExceptionWithInnerException.RetryAfter.Should().BeNull();
-        var dummyMessageExceptionWithInnerExceptionAndRetryAfter = new BrokenCircuitException("Dummy.", retryAfter, new InvalidOperationException());
-        dummyMessageExceptionWithInnerExceptionAndRetryAfter.Message.Should().Be("Dummy.");
-        dummyMessageExceptionWithInnerExceptionAndRetryAfter.InnerException.Should().BeOfType<InvalidOperationException>();
-        dummyMessageExceptionWithInnerExceptionAndRetryAfter.RetryAfter.Should().Be(retryAfter);
+        var exception = new BrokenCircuitException();
+        exception.Message.Should().Be("The circuit is now open and is not allowing calls.");
+        exception.RetryAfter.Should().BeNull();
+    }
+
+    [Fact]
+    public void Ctor_Message_Ok()
+    {
+        var exception = new BrokenCircuitException(TestMessage);
+        exception.Message.Should().Be(TestMessage);
+        exception.RetryAfter.Should().BeNull();
+    }
+
+    [Fact]
+    public void Ctor_RetryAfter_Ok()
+    {
+        var exception = new BrokenCircuitException(TestRetryAfter);
+        exception.Message.Should().Be($"The circuit is now open and is not allowing calls. It can be retried after '{TestRetryAfter}'.");
+        exception.RetryAfter.Should().Be(TestRetryAfter);
+    }
+
+    [Fact]
+    public void Ctor_Message_RetryAfter_Ok()
+    {
+        var exception = new BrokenCircuitException(TestMessage, TestRetryAfter);
+        exception.Message.Should().Be(TestMessage);
+        exception.RetryAfter.Should().Be(TestRetryAfter);
+    }
+
+    [Fact]
+    public void Ctor_Message_InnerException_Ok()
+    {
+        var exception = new BrokenCircuitException(TestMessage, new InvalidOperationException());
+        exception.Message.Should().Be(TestMessage);
+        exception.InnerException.Should().BeOfType<InvalidOperationException>();
+        exception.RetryAfter.Should().BeNull();
+    }
+
+    [Fact]
+    public void Ctor_Message_RetryAfter_InnerException_Ok()
+    {
+        var exception = new BrokenCircuitException(TestMessage, TestRetryAfter, new InvalidOperationException());
+        exception.Message.Should().Be(TestMessage);
+        exception.InnerException.Should().BeOfType<InvalidOperationException>();
+        exception.RetryAfter.Should().Be(TestRetryAfter);
     }
 
 #if !NETCOREAPP
     [Fact]
     public void BinarySerialization_Ok() =>
         BinarySerializationUtil.SerializeAndDeserializeException(new BrokenCircuitException()).Should().NotBeNull();
 #endif
+
+    private const string TestMessage = "Dummy.";
+    private static readonly TimeSpan TestRetryAfter = new(1, 0, 0);
 }
diff --git a/test/Polly.Core.Tests/CircuitBreaker/IsolatedCircuitExceptionTests.cs b/test/Polly.Core.Tests/CircuitBreaker/IsolatedCircuitExceptionTests.cs
@@ -5,23 +5,35 @@ namespace Polly.Core.Tests.CircuitBreaker;
 public class IsolatedCircuitExceptionTests
 {
     [Fact]
-    public void Ctor_Ok()
+    public void Ctor_Default_Ok()
     {
-        var dummyMessageException = new IsolatedCircuitException("Dummy.");
-        dummyMessageException.Message.Should().Be("Dummy.");
-        dummyMessageException.RetryAfter.Should().BeNull();
-        var defaultException = new IsolatedCircuitException();
-        defaultException.Message.Should().Be("The circuit is manually held open and is not allowing calls.");
-        defaultException.RetryAfter.Should().BeNull();
-        var dummyMessageExceptionWithInnerException = new IsolatedCircuitException("Dummy.", new InvalidOperationException());
-        dummyMessageExceptionWithInnerException.Message.Should().Be("Dummy.");
-        dummyMessageExceptionWithInnerException.InnerException.Should().BeOfType<InvalidOperationException>();
-        dummyMessageExceptionWithInnerException.RetryAfter.Should().BeNull();
+        var exception = new IsolatedCircuitException();
+        exception.Message.Should().Be("The circuit is manually held open and is not allowing calls.");
+        exception.RetryAfter.Should().BeNull();
+    }
+
+    [Fact]
+    public void Ctor_Message_Ok()
+    {
+        var exception = new IsolatedCircuitException(TestMessage);
+        exception.Message.Should().Be(TestMessage);
+        exception.RetryAfter.Should().BeNull();
+    }
+
+    [Fact]
+    public void Ctor_Message_InnerException_Ok()
+    {
+        var exception = new IsolatedCircuitException(TestMessage, new InvalidOperationException());
+        exception.Message.Should().Be(TestMessage);
+        exception.InnerException.Should().BeOfType<InvalidOperationException>();
+        exception.RetryAfter.Should().BeNull();
     }
 
 #if !NETCOREAPP
     [Fact]
     public void BinarySerialization_Ok() =>
         BinarySerializationUtil.SerializeAndDeserializeException(new IsolatedCircuitException("dummy")).Should().NotBeNull();
 #endif
+
+    private const string TestMessage = "Dummy.";
 }