Add new metering tests to cover uncovered lines (#1474)

App-vNext · Aug 10, 2023 · c8e0366 · c8e0366
1 parent 855ce01
commit c8e0366
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 2 deletions.
diff --git a/test/Polly.Extensions.Tests/Telemetry/ResilienceTelemetryDiagnosticSourceTests.cs b/test/Polly.Extensions.Tests/Telemetry/ResilienceTelemetryDiagnosticSourceTests.cs
@@ -12,8 +12,8 @@ public class ResilienceTelemetryDiagnosticSourceTests : IDisposable
     private readonly FakeLogger _logger;
     private readonly ILoggerFactory _loggerFactory;
     private readonly List<MeteringEvent> _events = new();
-    private readonly IDisposable _metering;
     private Action<TelemetryEventArguments>? _onEvent;
+    private IDisposable _metering;
 
     public ResilienceTelemetryDiagnosticSourceTests()
     {
@@ -290,6 +290,20 @@ public void WriteExecutionAttemptEvent_Metering_Ok(bool noOutcome, bool exceptio
         _events.Single(v => v.Name == "execution-attempt-duration").Measurement.Should().Be(50000);
     }
 
+    [Fact]
+    public void WriteExecutionAttemptEvent_ShouldBeSkipped()
+    {
+        _metering.Dispose();
+        _metering = TestUtilities.EnablePollyMetering(_events, _ => false);
+
+        var telemetry = Create();
+        var attemptArg = new ExecutionAttemptArguments(5, TimeSpan.FromSeconds(50), true);
+        ReportEvent(telemetry, Outcome.FromResult<object>(true), context: ResilienceContextPool.Shared.Get("op-key").WithResultType<bool>(), arg: attemptArg);
+
+        var events = GetEvents("execution-attempt-duration");
+        events.Should().HaveCount(0);
+    }
+
     [InlineData(1)]
     [InlineData(100)]
     [Theory]

diff --git a/test/Polly.TestUtils/TestUtilities.cs b/test/Polly.TestUtils/TestUtilities.cs
@@ -52,7 +52,7 @@ public static ILoggerFactory CreateLoggerFactory(out FakeLogger logger)
         return loggerFactory;
     }
 
-    public static IDisposable EnablePollyMetering(ICollection<MeteringEvent> events)
+    public static IDisposable EnablePollyMetering(ICollection<MeteringEvent> events, Predicate<Instrument>? shouldListen = null)
     {
         var stateStr = Guid.NewGuid().ToString();
         var meterListener = new MeterListener
@@ -61,6 +61,11 @@ public static IDisposable EnablePollyMetering(ICollection<MeteringEvent> events)
             {
                 if (instrument.Meter.Name == "Polly")
                 {
+                    if (shouldListen is not null && !shouldListen(instrument))
+                    {
+                        return;
+                    }
+
                     listener.EnableMeasurementEvents(instrument, stateStr);
                 }
             }