Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to FluentAssertions 6.x.x #913

Closed
martincostello opened this issue Jan 17, 2022 · 2 comments · Fixed by #918
Closed

Update to FluentAssertions 6.x.x #913

martincostello opened this issue Jan 17, 2022 · 2 comments · Fixed by #918
Milestone

Comments

@martincostello
Copy link
Member

Is your feature request related to a specific problem? Or an existing feature? Please describe.

Polly is currently using FluentAssertions 5.10.3, but the latest version at the time of writing is 6.3.0.

The change is a major breaking change, and simply updating the version number of the NuGet package introduces hundreds of compiler errors.

Describe your proposed or preferred solution:

Update Polly to the latest version of FluentAssertions and fix any compiler errors so it successfully builds and all the existing tests pass.

@mikkelbu
Copy link

I think I have time to take a look at this one.

@martincostello martincostello linked a pull request Feb 12, 2022 that will close this issue
4 tasks
@martincostello martincostello removed the help wanted A change up for grabs for contributions from the community label Feb 12, 2022
@martincostello martincostello added this to the v7.3.0 milestone Feb 13, 2022
@martincostello
Copy link
Member Author

Fixed by #918.

@martincostello martincostello modified the milestones: v7.3.0, v7.2.4 Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants