-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade FluentAssertions package #918
Upgrade FluentAssertions package #918
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up @ylr-research!
Other than the one comment, these changes all look reasonable.
The tests seem to be hanging somewhere. |
@martincostello, I just wrapped the kvp into a dictionary so it could compile on my end. I can't see the tests results. |
I would guess the problem is with one of the asynchronous tests you've changed, and the previous failure was masking it. |
I see 673 passed but it doesn't say which one failed |
I think that's the problem, it hasn't failed, it's still running and has hung. |
Do you think re-running could yield a different result? Otherwise, any suggestion on how to repro the one(s) hanging |
Not without going away and researching dotnet test parameters for helping to find such tests. Presumably these all pass when you run them locally using the build script? |
I missed that. I was just compiling in VS. |
1 similar comment
I missed that. I was just compiling in VS. |
I missed that. I was just compiling in VS. Let me check that |
I missed that. I was just building in VS. Let me try that |
@martincostello I found the issues. 30 tests not passing to be precise. All related to the same. Since I have changed |
c2296cf
to
c1a9462
Compare
Await all usages of Awaiting().
Thanks for your contribution @ylr-research - I cloned the PR locally and took a look at the code. The fundamental issue that was causing the deadlocks was that all the usages of |
Great, thanks |
The issue or feature being addressed
#913
Details on the issue fix or feature implementation
Upgrading FluentAssertions package to latest
Confirm the following