Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RetryForever - Documentation improvment? #944

Closed
willsmith9182 opened this issue Jun 23, 2022 · 0 comments · Fixed by #1574
Closed

RetryForever - Documentation improvment? #944

willsmith9182 opened this issue Jun 23, 2022 · 0 comments · Fixed by #1574
Labels
documentation enhancement help wanted A change up for grabs for contributions from the community v8 Issues related to the new version 8 of the Polly library.
Milestone

Comments

@willsmith9182
Copy link

willsmith9182 commented Jun 23, 2022

Is your feature request related to a specific problem? Or an existing feature? Please describe.
Documentation! huzzar

Describe your proposed or preferred solution:
RetryForever only retries up to int.MaxValue at which point the policy will return. Now depending on the work done in the policy delegate this could take an exceedingly long time but there's no clear indication in the docs that if you hit int.MaxValue retries you will get your last exception and the policy will stop retrying. That's not really forever, it's more 'long enough to seem like forever to you, human'.

A note on the docs for retries explaining this would be useful as it's hard to find a definitive answer when googling around. Forever != Forever in this case.

Describe any alternative options you've considered:

Any additional info?

@martincostello martincostello added enhancement documentation help wanted A change up for grabs for contributions from the community labels Jun 23, 2022
james-2001 added a commit to james-2001/Polly that referenced this issue Jan 6, 2023
martincostello added a commit that referenced this issue Jan 6, 2023
…n_improvment

#944- Added to readme explaining waitand/retryforever is not actually…
@martincostello martincostello added the v8 Issues related to the new version 8 of the Polly library. label Jun 16, 2023
@martincostello martincostello added this to the v8.0.0 milestone Jun 16, 2023
@github-project-automation github-project-automation bot moved this to Done in Polly v8 Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation enhancement help wanted A change up for grabs for contributions from the community v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants