Introduce Polly.Core #1053
Merged
Introduce Polly.Core #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martintmk
commented
Mar 13, 2023
geeknoid
approved these changes
Mar 13, 2023
geeknoid
reviewed
Mar 13, 2023
src/Polly.Core/Polly.Core.csproj
Outdated
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFrameworks>netstandard2.0;net461;net472;net6.0;net7.0</TargetFrameworks> |
There was a problem hiding this comment.
I don't think you need net472 here.
And in general, I recommend listing the TFMs from most recent to oldest. That way, when VS opens up, it will default to showing you the latest TFM.
There was a problem hiding this comment.
Good point, adjusted these.
martincostello
approved these changes
Mar 14, 2023
joelhulen
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue or feature being addressed
This PR adds a new
Polly.Coreproject where the V8 API will be implemented.Right from the start we want to enforce high code quality by:
Details on the issue fix or feature implementation
This PR prepares the Polly builds for the new project and does some cleanup around the build infrastructure. Mostly just moving some MSBuild properties to a props/targets to promote the reusability.
The size of this PR is somehow inflated because of the analyzer rules in
eng/analyzers, these are just recommended rules I copied from our code base and that we are using in production libraries.Confirm the following