-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce IResilienceStrategy and core primitives for V8 #1056
Conversation
Note that the default object pool in .NET has terrible scaling characteristics in scenarios where many pooled objects exist and are accessed in a concurrent fashion. The default pool was originally designed for very short-term object rentals and it just doesn't work well for long-term rentals. I fixed this for .NET 8. In the meantime, you may wish to grab the .NET 8 implementation here and use it instead of the default .NET object pool. https://github.com/dotnet/aspnetcore/blob/main/src/ObjectPool/src/DefaultObjectPool.cs |
My thinking is just to copy that code here since the revisited version is pretty simple. And we will avoid extra dependency. |
23fe66e
to
7a39b2c
Compare
7a39b2c
to
8cb24d5
Compare
The issue or feature being addressed
In this PR I am transferring some core primitives from v8-poc branch. This includes:
Details on the issue fix or feature implementation
To keep thing simple I am omitting the following:
ResilienceContext
instances.Execute
extensions as there will be many of these (to be done in follow-up).I'll include the tests once we agree on API shape.
Confirm the following