Introduce ResilienceStrategyBuilder #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| Validator.ValidateObject(Options, new ValidationContext(Options), true); | ||
|
|
||
| if (_entries.Count == 0) |
There was a problem hiding this comment.
Is there any benefit to special-casing a count of 1 to skip the loop and/or wrapping something that's just a pass-through?
martintmk
force-pushed
the
mtomka/introduce-IResilienceStrategyBuilder
branch
from
6b3f6bc to
d006124
Compare
martintmk
force-pushed
the
mtomka/introduce-IResilienceStrategyBuilder
branch
from
d006124 to
6f3f774
Compare
martintmk
changed the title
src/Polly.Core.Tests/Builder/ResilienceStrategyBuilderOptionsTests.cs
Outdated
Show resolved
Hide resolved
joelhulen
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue or feature being addressed
This PR adds a
ResilienceStrategyBuilderclass from v8-poc branch. It's used to build the instance ofIResilienceStrategy.Details on the issue fix or feature implementation
The following primitives are added:
ResilienceStrategyBuilder: the builder itself.ResilienceStrategyBuilderContext: context that caries details for the strategy factory.ResilienceStrategyBuilderOptions: the options of the builder. These will be epxanded later with more members such as clock, logging, telemetry.ResilienceStrategyOptions: the options attached to individual strategy.I'll add tests once we agree on the API surface.
Confirm the following