Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polly now references Polly.Core #1075

Merged
merged 5 commits into from
Mar 22, 2023
Merged

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Mar 21, 2023

The issue or feature being addressed

We will be moving some types from Polly to Polly.Core so Polly needs reference the core project. As a part of this we are also dropping support for legacy netstandard1.1 target.

Details on the issue fix or feature implementation

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk
Copy link
Contributor Author

@martincostello Do you have any idea how to get rid of this error?

Calculating coverage result...
  Generating report 'C:\Development\github\Polly\src\Polly.Specs\coverage.net7.0.cobertura.xml'

+------------+--------+--------+--------+
| Module     | Line   | Branch | Method |
+------------+--------+--------+--------+
| Polly.Core | 0%     | 0%     | 0%     |
+------------+--------+--------+--------+
| Polly      | 75.36% | 62.59% | 72.28% |
+------------+--------+--------+--------+

+---------+--------+--------+--------+
|         | Line   | Branch | Method |
+---------+--------+--------+--------+
| Total   | 69.46% | 60.44% | 64.86% |
+---------+--------+--------+--------+
| Average | 37.68% | 31.29% | 36.14% |
+---------+--------+--------+--------+

When testing Polly it also includes the Polly.Core into the report, thus decreasing the coverage.

@martincostello
Copy link
Member

You could either:

  • Combine the report with the other test leg(s) using a MergeWith property (example).
  • Add an Include property to only count the current assembly towards the coverage report (docs).

@martintmk martintmk merged commit d94f85f into main Mar 22, 2023
@martincostello martincostello deleted the mtomka/polly-references-core branch March 22, 2023 07:01
martincostello added a commit to martincostello/Polly that referenced this pull request Mar 22, 2023
Build and test in the order of the dependency tree since App-vNext#1075.
martincostello added a commit that referenced this pull request Mar 22, 2023
- Output a report in Cobertura format for coverlet.
- Write the reports to a stable directory path for coverlet upload.
- Build and test in the order of the dependency tree since #1075.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants