-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polly now references Polly.Core #1075
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@martincostello Do you have any idea how to get rid of this error?
When testing Polly it also includes the Polly.Core into the report, thus decreasing the coverage. |
martincostello
approved these changes
Mar 21, 2023
joelhulen
approved these changes
Mar 21, 2023
martincostello
added a commit
to martincostello/Polly
that referenced
this pull request
Mar 22, 2023
Build and test in the order of the dependency tree since App-vNext#1075.
Merged
martincostello
added a commit
that referenced
this pull request
Mar 22, 2023
- Output a report in Cobertura format for coverlet. - Write the reports to a stable directory path for coverlet upload. - Build and test in the order of the dependency tree since #1075.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue or feature being addressed
We will be moving some types
from Polly
toPolly.Core
so Polly needs reference the core project. As a part of this we are also dropping support for legacynetstandard1.1
target.Details on the issue fix or feature implementation
Confirm the following