Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce TimeProvider #1077

Merged
merged 4 commits into from
Mar 22, 2023
Merged

Introduce TimeProvider #1077

merged 4 commits into from
Mar 22, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Mar 22, 2023

The issue or feature being addressed

#1070

Details on the issue fix or feature implementation

This adds a TimeProvider API copied from .NET and made internal. We will use it internally in strategies until the official API and package is ready.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk self-assigned this Mar 22, 2023
@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Mar 22, 2023
@martintmk martintmk added this to the v8.0.0 milestone Mar 22, 2023
src/Polly.Core/Utils/TimeProvider.cs Outdated Show resolved Hide resolved
@martintmk martintmk merged commit 36ceee0 into main Mar 22, 2023
@martincostello martincostello deleted the mtomka/timeprovider branch March 22, 2023 14:49
@martincostello
Copy link
Member

For some reason, the Windows leg seems to be complaining about missing mutants and failing: logs

@martintmk
Copy link
Contributor Author

martintmk commented Mar 22, 2023

@martincostello

Will take a look. I think we should also try to always upload the mutation-report so we know where the problem is:

https://github.com/App-vNext/Polly/blob/main/.github/workflows/build.yml#L55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants