Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always attempt to upload mutation report #1078

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Mar 23, 2023

The issue or feature being addressed

We have seen mutants that were not killed in some builds. Because the mutation report was not uploaded, we couldn't determine the cause. With this change, we always try to upload the mutation reports.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2023

Codecov Report

Merging #1078 (38b4923) into main (36ceee0) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #1078   +/-   ##
=======================================
  Coverage   73.83%   73.83%           
=======================================
  Files         161      161           
  Lines        4086     4086           
  Branches      775      775           
=======================================
  Hits         3017     3017           
  Misses        864      864           
  Partials      205      205           
Flag Coverage Δ
linux 73.83% <ø> (?)
macos ?
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@martintmk martintmk merged commit e82485d into main Mar 23, 2023
@martintmk martintmk deleted the mtomka/always-upload-mutation-report branch March 23, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants