-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Polly.Extensions project #1088
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1088 +/- ##
==========================================
+ Coverage 75.04% 75.10% +0.06%
==========================================
Files 173 173
Lines 4243 4254 +11
Branches 790 791 +1
==========================================
+ Hits 3184 3195 +11
Misses 854 854
Partials 205 205
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
src/Polly.Hosting/DependencyInjection/ConfigureResilienceStrategyRegistryOptions.cs
Outdated
Show resolved
Hide resolved
src/Polly.Hosting/DependencyInjection/PollyServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
src/Polly.Hosting/DependencyInjection/PollyServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
src/Polly.Hosting/DependencyInjection/PollyServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
<Project Sdk="Microsoft.NET.Sdk"> | ||
<PropertyGroup> | ||
<TargetFrameworks>net7.0;net6.0;netstandard2.0;net472;net462</TargetFrameworks> | ||
<AssemblyTitle>Polly.Hosting</AssemblyTitle> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Polly.Hosting
doesn't sound right => Polly.Extensions
?
We could then follow the familiar pattern with Polly.Extensions.DependencyInjection
Just my two outstanding comments from yesterday. |
@martincostello Sorry, but I do not see any that I did not respond to. Are they lost somewhere? :) |
This one and the other it turns out wasn't submitted 😅 |
The issue or feature being addressed
#1087
Details on the issue fix or feature implementation
Enables the configuration of
ResilienceStrategy
using the DI and additional extensibility. The API exposes only a singleAddResilienceStrategy
public extension forIServiceCollecion
. Additional extensibility can be done usingIOptions
pattern.Additional Changes:
Confirm the following