Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pooling of CancellationTokenSources #1116

Merged
merged 3 commits into from
Apr 13, 2023
Merged

Pooling of CancellationTokenSources #1116

merged 3 commits into from
Apr 13, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Apr 12, 2023

Details on the issue fix or feature implementation

This PR adds pooling of CancellationTokenSource on .NET 6.0+ runtimes.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2023

Codecov Report

Merging #1116 (295c903) into main (97c2307) will increase coverage by 0.05%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1116      +/-   ##
==========================================
+ Coverage   77.78%   77.83%   +0.05%     
==========================================
  Files         200      201       +1     
  Lines        4766     4777      +11     
  Branches      851      851              
==========================================
+ Hits         3707     3718      +11     
  Misses        854      854              
  Partials      205      205              
Flag Coverage Δ
linux 77.83% <100.00%> (+0.05%) ⬆️
macos 77.83% <100.00%> (+0.05%) ⬆️
windows 77.83% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Polly.Core/Utils/TimeProviderExtensions.cs 100.00% <ø> (ø)
...rc/Polly.Core/Timeout/TimeoutResilienceStrategy.cs 100.00% <100.00%> (ø)
...rc/Polly.Core/Utils/CancellationTokenSourcePool.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@martintmk martintmk merged commit 80f5791 into main Apr 13, 2023
@martintmk martintmk deleted the mtomka/cts-pooling branch April 13, 2023 07:17
@martintmk martintmk restored the mtomka/cts-pooling branch April 13, 2023 10:50
@martincostello martincostello deleted the mtomka/cts-pooling branch April 14, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants