Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop ResilienceStrategyBuilderOptions #1117

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Drop ResilienceStrategyBuilderOptions #1117

merged 1 commit into from
Apr 13, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Apr 13, 2023 •
edited
Loading

Details on the issue fix or feature implementation

Having ResilienceStrategyBuilderOptions is artificial. We can just put these properties to ResilienceStrategyBuilder and simplify the API.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk self-assigned this Apr 13, 2023
@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Apr 13, 2023
@martintmk martintmk added this to the v8.0.0 milestone Apr 13, 2023
@martintmk martintmk enabled auto-merge (squash) April 13, 2023 14:51
@martintmk martintmk merged commit 2e6d7a0 into main Apr 13, 2023
@martintmk martintmk deleted the mtomka/drop-ResilienceStrategyBuilderOptions branch April 13, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martincostello martincostello martincostello approved these changes

Assignees

@martintmk martintmk

Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Polly v8
Status: Done
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@martintmk @martincostello