-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop ResilienceTelemetryFactory #1123
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1123 +/- ##
==========================================
+ Coverage 77.71% 77.88% +0.16%
==========================================
Files 200 202 +2
Lines 4753 4788 +35
Branches 850 858 +8
==========================================
+ Hits 3694 3729 +35
Misses 854 854
Partials 205 205
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
c2ddf15
to
e5c110e
Compare
e5c110e
to
eae2d2f
Compare
Details on the issue fix or feature implementation
This PR drops the following public APIs:
ResilienceTelemetryFactory
NullResilienceTelemetryFactory
NullResilienceTelemetry
The
ResilienceTelemetry
stays public and strategies can use it to report important resilience events. Its signature is expanded to allow passing additional arguments. Internally,ResilienceTelemetry
usesDiagnosticSource
to report events. InPolly.Extensions
we will subscribe to thisDiagnosticSource
and report the events as logs and metrics.Additional changes:
Outcome
struct.DiagnosticSource
by specifying it inResilienceStrategyBuilder.Properties
.Confirm the following